"q" keyboard shortcut not working

Continuing the discussion from Various keyboard shortcuts no longer working:

It seems to have become unfixed…

2개의 좋아요

Ah this is why it stopped working :stuck_out_tongue:

https://github.com/discourse/discourse/blob/master/app/assets/javascripts/discourse/lib/keyboard-shortcuts.js.es6#L103

The CSS class is still not updated and is using the old composer’s class.
Can’t submit a PR now because I’m away from my dev pc

Anyway, I think we should keep the IDs of the composer’s button as constants and export them to be used in the keyboard shortcuts. This will allow us to avoid having to change the CSS class in multiple places. Is that ok @eviltrout?

4개의 좋아요

PR :allthethings:

https://github.com/discourse/discourse/pull/3906/files

4개의 좋아요