Les guillemets dans le nom complet gâchent le markdown des citations

zogstrip · Décembre 12, 2025, 5:49

J’ai bien peur que non

Le plus simple et le plus sûr est de les supprimer, ce n’est pas idéal, mais mieux que d’avoir un rendu cassé j’imagine ?

github.com/discourse/discourse

FIX: strip quotation marks from names in quote BBCode

main ← strip-quotation-marks-from-names-in-quote-bbcode

opened 05:48PM - 12 Dec 25 UTC

ZogStriP

+31 -2

When "display name on posts" is enabled and "prioritize username in UX" is disab…led, quoting a user with quotation marks in their display name (e.g., `John "The Dev" Smith`) breaks the quote markdown: [quote="John "The Dev" Smith, post:1, topic:2"] The BBCode parser's regex `"([^"]+)"` stops at the first `"` inside the name, capturing only `John ` instead of the full name. Alternatives considered: - Backslash escaping (`\"`): Would require updating the parser regex to support escape sequences and adding unescape logic. Adds complexity and risks breaking existing quotes. - URL encoding (`%22`): Requires decoding when rendering. Using `decodeURIComponent` on user input creates XSS risk. A safe decoder that only decodes specific characters adds complexity and attack surface for minimal benefit. The simplest solution is to strip quotation marks from names when building the quote BBCode. This is safe (no user input decoding), simple (no parser changes), and the minor cosmetic loss in the quote attribution is an acceptable trade-off. The `stripQuotationMarks` function is defined alongside the existing `QUOTATION_MARKS` array in bbcode-block.js to keep related logic together and avoid duplication. Ref - https://meta.discourse.org/t/391153

Sujet		Réponses	Vues
Quoting broken when name matches username Bug	21	1821	Avril 27, 2022
[quote] loses backslashes on this super edge case Bug markdown-it-review	4	1106	Juin 26, 2017
Can a Theme have a quote display real name instead of username? Feature	2	675	Mai 22, 2020
Quote context impacts functionality of quote Support	14	1393	Juillet 3, 2023
"display name on posts" should apply to quotes, too Feature	0	425	Janvier 13, 2021

Les guillemets dans le nom complet gâchent le markdown des citations

Sujets connexes