Race condition on topic assign

Fehler
1

Found a small bug (race condition?) @sam. Two different users can assign the topic at the same time.

image
image.png778×128 6.82 KB

5 „Gefällt mir“
3

Not much we can do here sadly, we allow already assigned topics to be assigned to somebody new.

1 „Gefällt mir“
4

This is not a new person though it is the same person.

3 „Gefällt mir“
5

Ahh did not notice that, I guess we can error out here.

2 „Gefällt mir“
6

pr-welcome for:

  • IF topic is already assigned
  • AND you are attempting to assign to the same person already assigned
  • RAISE A non 400 error “Topic is already assigned to XYZ” and display to client.
  • Test on both mobile and desktop
  • Include a controller test at least in the PR
4 „Gefällt mir“
7

Hi,
I will try to submit PR for this.

Thanks

8 „Gefällt mir“
8

This is fixed now.

https://github.com/discourse/discourse-assign/commit/a2e7fc4cace440114e73ad4ab85f650a9ab30dea

6 „Gefällt mir“
9

This topic was automatically closed after 34 hours. New replies are no longer allowed.