Race condition on topic assign

[jomaxro (Joshua Rosenfeld)]

Found a small bug (race condition?) @sam. Two different users can assign the topic at the same time.

[sam (Sam Saffron)]

Not much we can do here sadly, we allow already assigned topics to be assigned to somebody new.

[codinghorror (Jeff Atwood)]

This is not a new person though it is the same person.

[sam (Sam Saffron)]

Ahh did not notice that, I guess we can error out here.

[sam (Sam Saffron)]

pr-welcome for:

• IF topic is already assigned
• AND you are attempting to assign to the same person already assigned
• RAISE A non 400 error “Topic is already assigned to XYZ” and display to client.
• Test on both mobile and desktop
• Include a controller test at least in the PR

[saurabhp (Saurabh Patel)]

Hi,
I will try to submit PR for this.

Thanks

[saurabhp (Saurabh Patel)]

This is fixed now.

https://github.com/discourse/discourse-assign/commit/a2e7fc4cace440114e73ad4ab85f650a9ab30dea