Re-adding missing uploads to the database

Suporte
1

I’ve got a site where it seems that a bunch of uploads have been removed from the uploads table in the database, but still exist in the filesystem. This leaves links to these broken. I’ve fixed a few by re-uploading files into a new topic to create the record in the DB (at the time I thought that the files were missing too, but @angus graciously pointed out why I wasn’t finding them–One day I’ll ask: why do we have both sha1 and base62 names for all of these assets?) and then re-baking the posts that include those uploads, like this:

def rebake_posts_with_uploads(topic_id, post_number)
  p = Post.find_by(topic_id: topic_id, post_number: post_number)
  exit unless p
  re = /upload:\/\/(.+?)\)/
  shas= p.raw.scan(re)

  shas.each do |sha|
    posts = Post.where("raw like '%#{sha[0]}%'")
    next unless posts
    puts "Found #{posts.count - 1} #{sha[0]}"
    posts.each do |post|
      next if post.id == p.id
      puts "rebake #{post.id}--#{BASE_URL}/t/-/#{post.topic_id}/#{post.post_number}"
      post.rebake!
    end
  end
end

My new plan, since it seems that the files exist in the file system but not in the database, is to do something like this:

for (all files in /shared/uploads/default/original/1x) do |file|
  unless file is in uploads table
     create upload record 
     for each post that includes that upload record
       rebake

Does that seem right? I’m looking at uploads.rake and don’t see anything that seems to do this already. This is sort of the opposite of

but instead of FileUtils.rm(file_path) I’d instead do an Upload.create, I think.

If this seems really stupid or there is a much better solution, I’d love to hear it before I go down this little rabbit hole.

Thanks.

I don’t know how this happened. I was hoping to pin the blame on a custom plugin, but I’m afraid that’s not the case. It may be related to another discussion, in which someone said:

3 curtidas
2

Yeah our history here with uploads is quite spotty, and it is our fault… @sam can you recommend someone to give a quick bit of advice?

2 curtidas
3

This can work, you just have to be careful to test on local … also look at 2x / 3x directories there are uploads everywhere.

3 curtidas
4

I’m trying something like this:

def add_missing_files_to_uploads
  public_directory = Rails.root.join("public").to_s
  db = RailsMultisite::ConnectionManagement.current_db
  uploads_directory = File.join(public_directory, 'uploads', db).to_s
  # uploads and optimized images
  missing = 0
  matched = 0
  Dir.glob("#{uploads_directory}/**/*.pdf").each do |file_path|
    sha1 = Upload.generate_digest(file_path)
    url = file_path.split(public_directory, 2)[1]
    if (Upload.where(sha1: sha1).empty? &&
        Upload.where(url: url).empty?)
      puts "MISSING #{file_path}" if DEBUG
      missing += 1
    else
      matched += 1
    end
  end
  puts "MISS: #{missing}. Match #{matched}"
end

Does that look sort of close? My first test seems to have failed, but I might have screwed something up.

5

Hi @pfaffman. I was reading this topic as it looks a promising solution for my problem here.
Did you manage to get to a good result in the end?

6

Sorry, I can’t remember.

It looks to Sam and me like it’ll work.

I just solved a simulator problem by creating a post and into it inserting a link to all of the images and then rebaking all of the posts that contain transparent.gif.

This looks like a somewhat more elegant solution.

I would say make a database-only backup and give it a try. I’m sort of on vacation, but if you have a budget I can see what I can do.

And I too have an important client on ams3; I’ve not yet moved them to aws, but I think that’s happening soon. I have a friend who worked for digital ocean who recommended ams3 because it was their best data center and was largely underutilized (this was now long ago). That didn’t work out as I’d hoped.

1 curtida
7

Eu me pergunto se este é o melhor método hoje em dia?

Estou tentando recuperar uploads que estão no sistema de arquivos, mas não no banco de dados, após uma migração S3 ruim (com o antigo rake:s3_migrate).

8

Não há realmente um bom método. :crying_cat:

Mas, sim. Essa ainda é a ideia. Eu não acho que nada tenha mudado no Discourse desde então. Normalmente, eu faria alguns manualmente para garantir que ele faça o que é esperado. Além disso, faça um backup primeiro e talvez coloque o site em modo somente leitura para que, se você precisar restaurar o backup, não precise descartar nenhuma postagem feita enquanto você estava mexendo nas coisas.

Sem saber muito mais do que é fácil comunicar em um fórum, não posso dizer se essa é realmente a melhor maneira ou se há algo mais simples. Você pode ser capaz de apenas usar gsub nos caminhos dos URLs, por exemplo. Se você tiver um orçamento, pode entrar em contato comigo ou perguntar em Marketplace.

1 curtida