pinder99
(Pushpender Singh)
15 فبراير 2024، 7:02ص
1
If you click on recent search like in below image , it becomes blank
إعجابَين (2)
sam
(Sam Saffron)
15 فبراير 2024، 7:29ص
3
Thanks for reporting, looks like a recent regression.
I also think @pmusaraj that it is a bit odd to totally hide recent searches when you are in a topic, cause it makes the feature so much more hidden.
Odds are super high you are always going to be doing global searches vs in topic searches.
إعجابَين (2)
pmusaraj
(Penar Musaraj)
15 فبراير 2024، 6:40م
5
Yeah, I agree. We could certainly include recent searches in more contexts. I would avoid them when you’re in PMs or group inboxes, but otherwise, if there are no cached results, seems reasonable to show your recent searches.
إعجاب واحد (1)
isaac
(Isaac Janzen)
15 فبراير 2024، 6:47م
6
Thank you @pinder99 for the report. Much appreciated. This will be fixed by
discourse:main
← discourse:update-recent-search
opened 06:38PM - 15 Feb 24 UTC
- Make clicking a recent search item populate the search input with said value
… - Don't add empty search strings to recent search history.
إعجاب واحد (1)
isaac
(Isaac Janzen)
15 فبراير 2024، 7:39م
7
We could do something like this
discourse:main
← discourse:show-initial-options-for-more-contexts
opened 07:34PM - 15 Feb 24 UTC
Add search history to 👇 contexts:
- "topic",
- "category",
- "tag",
… - "tagIntersection",
- "user",
We display the search history when no search term is present.
# Demo
https://github.com/discourse/discourse/assets/50783505/c720f70e-0c4c-4dbd-9f28-8b046deef674
## Topic
<img width="1003" alt="Screenshot 2024-02-15 at 12 36 37 PM" src="https://github.com/discourse/discourse/assets/50783505/5a254d94-2489-4c0f-976d-0eb1e2d6d775">
## Category
<img width="1003" alt="Screenshot 2024-02-15 at 12 36 23 PM" src="https://github.com/discourse/discourse/assets/50783505/247ec625-0bc2-431b-ae4f-b4e664647cfe">
## Tag
<img width="1020" alt="Screenshot 2024-02-15 at 12 35 50 PM" src="https://github.com/discourse/discourse/assets/50783505/e416a935-00c2-4e8a-aef4-8de6903864bf">
## Tag Intersection
<img width="1004" alt="Screenshot 2024-02-15 at 12 35 28 PM" src="https://github.com/discourse/discourse/assets/50783505/d06cb287-52dd-4df4-ade8-75f30f67f07e">
## User
<img width="1001" alt="Screenshot 2024-02-15 at 12 34 51 PM" src="https://github.com/discourse/discourse/assets/50783505/85a7a682-46f5-404c-a441-affb6bad05b6">
cc @sam
إعجابَين (2)
isaac
(Isaac Janzen)
تم إغلاقه في
26 فبراير 2024، 2:00م
9
This topic was automatically closed after 10 days. New replies are no longer allowed.