Redirects on load remove URL parameters

[Firepup650 (Firepup Sixfifty)]

Noticed this a while ago, just remembered it.

Sometimes, I publicly post links on our forum to a theme preview link so others can see new changes before they’re applied to all themes. I’ll give out a link like: https://amcforum.wiki/t/author-badges-theme-component-side-wide/2262?preview_theme_id=56
Which is long, so I’ll try to shorten it to: https://amcforum.wiki/t/2262?preview_theme_id=56
But that doesn’t work, because when it redirects to the full topic URL it strips off the preview theme.

The same thing occurs with safe mode query params.

[awesomerobot (Kris)]

Someone with a better understanding of our routing will hopefully chime in… but this might be more of a feature request than a bug.

I’m not sure query parameters were ever intended to be included with those short links — my understanding is that when a short link is used the application checks for the permalink, and redirects to that… so the query param would need to be lifted off the short link and reapplied to the permalink to get this working.

[Firepup650 (Firepup Sixfifty)]

Interesting, I didn’t know it worked that way.

(Likely due to that same functionality) if a topic’s title changes, the same issue/behavior occurs.

[tgxworld (Alan Tan)]

This has been fixed in

https://github.com/discourse/discourse/pull/23965

[Firepup650 (Firepup Sixfifty)]

Does that fix also apply to safe_mode params?