akvadrako
7. September 2020 um 14:57
1
I am using discourse 2.6.0.beta1 with relative_url_root = /forum and I have noticed a couple issues.
One issue is that several links, for example “Latest” on the main page, point to /latest instead of /forum/latest. The links do work, but the status bar shows the incorrect value when hovering.
Another issue is that I was trying to see if I could make links to categories without the trailing number, like /forum/c/staff. This doesn’t work because it redirects to /forum/forum/c/staff/3.
They are not major problems, but I thought I would report them since it doesn’t seem like they are known bugs.
4 „Gefällt mir“
pfaffman
7. September 2020 um 15:29
2
Subfolder issues do creep in. Are you on latest?
1 „Gefällt mir“
akvadrako
7. September 2020 um 16:20
3
I have just upgraded to latest and I see the same behavior.
4 „Gefällt mir“
pfaffman
11. September 2020 um 16:04
6
I’m seeing admin confirmation links with the relaztive_url_root duplicated on 2.5.0.
1 „Gefällt mir“
techAPJ
16. September 2020 um 06:45
7
Fixed via:
committed 06:39AM - 16 Sep 20 UTC
https://meta.discourse.org/t/relative-url-root-issues-incorrect-latest-link-inco… rrect-redirect/163266
URLs like `/forum/c/staff` (subfolder setup) were landing on
`/forum/forum/c/staff/3`. Note the extra "/forum". This commit
strips the redundant subfolder path from category URL.
I’m unable to repro both of the above issues on latest Discourse version.
pfaffman
16. September 2020 um 14:50
8
Thanks, Arpit. These people (whose installation I’m not managing) are on 2.5.0. Can you help me understand where confirm_admin_url gets defined so that I can confirm that it’s a bug in their version of Discourse?
This is on 2.5.0.
The admin confirmation URL in the email has subfolder duplicated. like
https://www.example.com/subfolder/subfolder/u/confirm-admin/key.
I’m looking at
https://github.com/discourse/discourse/blob/master/app/mailers/admin_confirmation_mailer.rb#L12
it appears to call something called confirm_admin_url, but I can’t find where that’s defined.
I’m not sure where to look to see if it’s a bug or some configuration issue (but this is the only place this problem is showing up).
class AdminConfirmationMailer < ActionMailer::Base
include Email::BuildEmailHelper
def send_email(to_address, target_email, target_username, token)
build_email(
to_address,
template: "admin_confirmation_mailer",
target_email: target_email,
target_username: target_username,
admin_confirm_url: confirm_admin_url(token: token, host: Discourse.base_url),
)
end
end
Thanks.
1 „Gefällt mir“
techAPJ
16. September 2020 um 15:05
9
This is on 2.5.0.
The admin confirmation URL in the email has subfolder duplicated. like
https://www.example.com/subfolder/subfolder/u/confirm-admin/key.
I’m looking at
https://github.com/discourse/discourse/blob/master/app/mailers/admin_confirmation_mailer.rb#L12
it appears to call something called confirm_admin_url, but I can’t find where that’s defined.
I’m not sure where to look to see if it’s a bug or some configuration issue (but this is the only place this problem is showing up).
I just replied on above topic.
1 „Gefällt mir“
