Render %{invitee_name} as full name only

贡献 用户体验
1

When usernames are derived from emails (especially work emails), they often are very similar to the users real name. If the user has set their real name (and if real names are not hidden via site settings) this currently results in invite emails starting like this

John Doe (doe) invited you to join

As far as I can tell without any knowledge of ruby, this is where the John Doe (doe) part gets rendered:

I don’t see the benefit of mentioning the username at all if the real name is available. After all, you are inviting someone who is not yet a member (most of the time at least) and hence can’t relate to the username anyway. So I would like to change line 18 to

  invitee_name = "#{invite.invited_by.name}"

but I don’t know how to achieve this on my site and I’m also hesitant to fiddle with the core code. Is this a change that would make sense for the core? If not, could someone give me some hints how to make that change locally while maintaining upgradability?

BTW: why is the variable called invitee_name when “invitee” commonly designates the invited person, not the inviting person?

So, just to understand things better, does what I’m trying to do imply forking Discourse? I hope there is a simpler way for making such a minor change…

8 个赞
2

我本来想创建一个 Contribute > Bug 主题来讨论这个问题，但既然有人提到了，我就直接在这里支持一下。

“Invitee” 确实指的是被邀请的人。发出邀请的人应该是 inviter 或 invitor。参考：https://english.stackexchange.com/questions/327842/person-who-invites-inviter-or-invitor。

在编辑邀请相关的邮件模板时，这一点尤其令人困惑。我以为 %{invitee_name} 会填入我邀请的人的名字，于是我就把句子改成了这样，结果发出的邀请完全讲不通，因为 %{invitee_name} 实际上插入的是创建邀请的人的用户名。

我支持楼主在这个话题中提出的建议，如果可用，请使用全名，而不是用户名，因为用户名对新手用户来说可能不太直观。

但我们确实需要将 %{invitee_name} 改为 %{inviter_name}，因为这非常令人困惑，而且不准确。我可能能够自己完成这个修改，如果你有兴趣，我可以提交一个 PR。

9 个赞
Change to using %{inviter_name} in locale files may have broken email templates
3

Yeah this is bad and wrong, you are 100% correct. Not sure who worked on this originally, but they got it wrong.

  • Invitee: person being invited

  • Inviter: person sending the invitation

Can you add to your list @techAPJ?

6 个赞
4

What abour the main point of the OP? Do you intend to make that change too?

1 个赞
5

Done via:

https://github.com/discourse/discourse/commit/0e0794dff9e23f5ee5ba5f68a8a04f08254b4790

and

https://github.com/discourse/discourse/commit/248ad5466d5009476fb7170e878096a3e343ec1c

4 个赞
6

I have created a PR for this:

https://github.com/discourse/discourse/pull/5390

@codinghorror can merge if he agrees. :slight_smile:

5 个赞
7

I disagree; you’ll need the username to mention the person properly. Also highly relevant if they are different:

Joe Smith @ninja

8

I don’t understand your point. Can you elaborate?

9

I think often both could be needed.

If the invite said codinghorror only and I knew Jeff personally I might not have any idea who codinghorror was and be reluctant to accept the invite.

If the invite said Jeff only and I knew Jeff personally I would be more likely to accept the invite, but I might not know that his member name was codinghorror.

3 个赞
10

That part is covered: the proposal is only to skip username if real name is available, not the other way around.

I believe when you follow an invite link you get to see the name, username and avatar of the user who invited you. Is that not so?

1 个赞
11

This topic was automatically closed after 33 hours. New replies are no longer allowed.