Reorder Categories stopped working?

[sallypf (Sally)]

Hi All, On my forum Psychics Forum reorder categories has stopped working which I suspect may have happened after some recent upgrades.

When I click on Reorder Categories menu it doesn’t do anything. How do we fix it?

[JammyDodger]

Hello and welcome @sallypf

I can confirm this here on meta as well. I’ve slipped this over to the Contribute > Bug category and we’ll get it looked at.

[sallypf (Sally)]

Oh ok, will wait then. Thanks for the reply.

[Arkshine]

Error

Related to:
https://github.com/discourse/discourse/pull/24209

And specifically:

https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/app/components/discovery/navigation.js#L59

I believe it misses a @service modal; here:

https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/app/components/discovery/navigation.js#L10-L12

[sallypf (Sally)]

Is it suggestion or solution?

[GuidoD (Guido Drehsen)]

it is not yet a solution, just a hint where they have to check the code in order to fix it.
I would expect that it will be fixed somewhere next week.

[sam (Sam Saffron)]

We have this assigned out, should be sorted out this week.

[david (David Taylor)]

Thanks everyone! This should be fixed via

https://github.com/discourse/discourse/commit/1e1bb45b969093731cb6c252af3c66147ecbb286

[GuidoD (Guido Drehsen)]

@david

This should be fixed via

yes it is fixed now, I just pulled the latest release and after a forced reload of the site the popup is back for the sorting and the categories got reordered successfully at our site.