Request: Add the Zulip brand icons to the vendored Font Awesome sprite

Contribute Feature
1

Howdy from the Julia Discourse!

Zulip has now landed as a Font Awesome brand icon (7.2+). Core’s @fortawesome/fontawesome-free package is already on 7.3.1, but the sprite that gets served is still built from v6.6.0, so it seems fab-zulip cannot be enabled through the svg icon subset setting yet.

We’d like to get fab-zulip and fab-circle-zulip added to that vendored sprite, similarly to UX: update twitter icon for X, add threads & mastodon icons - Pull Request #26203 - discourse/discourse - GitHub (following the request in Add temporary Threads logo to current Font Awesome version). We’re happy to open a PR following that pattern, but I just wanted to check here first whether that is still the right way to go about it.

Thanks in advance for your guidance!

4 Likes
2

Now that you mention it, we should have a better process for keeping these up to date so these additions don’t need to be a special request and we don’t lag too far behind.

I’ll take a look and see what we can do, if you want to open a PR to add the icon in the meantime I can have a look and get it merged for you… following that previous pattern should be fine.

3 Likes
3

Thanks! Opened here: https://github.com/discourse/discourse/pull/43564

1 Like