مطلوب: true غير مفروض لحقل الرفع في قوالب النماذج

zogstrip · 23 مارس 2026، 6:23م

ملاحظة جيدة يجب إصلاحها بواسطة

github.com/discourse/discourse

FIX: Enforce `required` validation on form template upload field (#38799)

main ← fix/form-template-upload-required-validation

opened 06:23PM - 23 Mar 26 UTC

ZogStriP

+100 -2

The `required: true` validation on upload fields in form templates was not being… enforced. Users could submit forms without attaching any file even when the upload field was marked as required. The root cause is that the upload field used a `<input type="hidden">` to store its value. Hidden inputs are excluded from the browser's constraint validation API — `form.checkValidity()` skips them entirely. All other form template field types (input, textarea, dropdown, etc.) use visible form elements where the native `required` attribute works. The fix changes the hidden input to a visually-hidden `<input type="text">` so that native constraint validation applies. The input is positioned off-screen via CSS and made non-interactive with `tabindex="-1"` and `aria-hidden="true"`. It is also placed as the last child in the container so the validation error message (inserted via `insertAdjacentElement("afterend")`) renders in a visible location. A synthetic `input` event is dispatched after upload completion so the validation error clears once a file is attached. https://meta.discourse.org/t/398972

الموضوع		الردود	مرات العرض
'Upload Fails' error when using form templates Bug form-templates	8	603	3 نوفمبر 2023
Hidden upload field is not hidden UX fixed	1	91	17 مارس 2025
Checkbox Validation: No Error Message Shown When Required Support form-templates	0	71	27 يونيو 2025
Topic template cannot allow user to upload media, and the 3 lines at the top do nothing Support form-templates	3	360	24 مارس 2024
Creating form templates Site Management form-templates	1	465	11 مارس 2026

مطلوب: true غير مفروض لحقل الرفع في قوالب النماذج

الموضوعات ذات الصلة