Retry-After 返回 0 秒

andrei · 2021 年1 月 12 日 16:52

事实证明，问题并不出在 Lua 脚本的舍入上。Lua 脚本接收到的已经是舍入后的值。

此外，这根本不是舍入问题。即使使用未舍入的秒数，仍然有可能收到带有 Retry-After: 0 的 429 响应。

以下是针对主要问题的修复方案：

github.com/discourse/discourse

FIX: sliding window end time in rate limiter (#11691)

master ← AndrewPrigorshnev:fix/sliding-window-end-time-in-rate-limiter

merged 06:26PM - 12 Jan 21 UTC

AndrewPrigorshnev

+17 -8

If the sliding window size is N seconds, then a moment at the Nth second should …be considered as the moment outside of the sliding window. Otherwise, if the sliding window is already full, at the Nth second, a new call wouldn't be allowed, but a time to wait before the next call would be equal to zero, which is confusing. In other words, the end of the time range shouldn't be included in the sliding window. Let's say we start at the second 0, and the sliding window size is 10 seconds. In the current version of Rate Limiter, this sliding window will be considered as a time range `[0, 10]` (including the end of the range), which actually is 11 seconds in length. After this fix, the time range will be considered as `[0, 10)` (excluding the end of the range), which is exactly 10 seconds in length.

以下是针对偶尔会导致相同错误的额外问题的修复方案：

话题		回复	浏览量
When rate limiting is hit return return a Retry-After header Feature pr-welcome	4	1457	2024 年7 月 19 日
0 second post wait? Feature	10	787	2018 年6 月 18 日
Handling of crawler throttling Support seo	3	465	2023 年9 月 12 日
Discourse API Generating 429 Support	7	637	2023 年3 月 28 日
User_10_secs_limit Development	7	225	2025 年7 月 10 日

Retry-After 返回 0 秒

相关话题