S3 CDN URL ignored when uploading into posts

貢献 バグ
1

All of our traffic goes through CloudFront, and static content is fetched by CloudFront from one of several S3 buckets.

With uploads being sent to S3, Discourse embeds the content with a generic bucket URL despite our having s3 cdn url set. Once submitted, posts appear to use the correct URL set in s3 cdn url, although this may also be because we have DISCOURSE_CDN_URL set as well (both are set to the same URL).

The post preview window references the standard S3 URL seen in the unbaked post, though. This is a problem because we use a private ACL on files uploaded to our Discourse uploads bucket, as content on this bucket should never be accessed outside of CloudFront. The result is a broken image in the preview window.

Pasted image1053×119 12 KB

「いいね！」 2
System upload not using s3 cdn url
Migrating uploads to s3 does not work with private bucket
Custom emoji don't use CDN for S3 stored assets in a few pages
2

Disappointing this has been reported for so many years with no fix.

@DanielMarquard Did you ever figure out a workaround, or were you forced to make your s3 ACL public?

3

I’m not sure it’s fair to suggest this is broken, as much as the more complicated implementation isn’t fully supported.

S3 uploads as documented work and behave correctly.

4

@Stephen Certainly up for interpretation…

To me it seems “broken” that it uses the CDN url in one instance and not the other, and it forces an S3 configuration that AWS actually recommends against (public ACL for an s3 bucket).

I’m new to the Discourse project in general, but can certainly work on a PR.

S3 CDN URL not being used on non-image uploads
5

This may be worth fixing now - AWS is getting more serious about informing people of public read ACLs.

「いいね！」 4
6

Given our current implementation no longer has an IMG tag eg:

image
image.png908×393 55 KB

![image|690x298,50%](upload://eGAOR4Xy4aRM2lwPIuTokBf60jS.png)

It should be quite easy to apply a CDN to the above and it saves traffic.

@vinothkannans can you fix this up so preview uses the CDN url

Instead of preview showing:

<img src="//assets-meta-cdck-prod-meta.s3.dualstack.us-west-1.amazonaws.com/original/3X/6/6/66ef078b3ef9da9aa1b3356cb21fe22a0d25eaf0.png" alt="image" class="resizable" width="345" height="149">

We should show the CDN URL which is this:

<img src="https://d11a6trkgmumsb.cloudfront.net/original/3X/6/6/66ef078b3ef9da9aa1b3356cb21fe22a0d25eaf0.png" alt="image" class="resizable" width="345" height="149">
「いいね！」 6
8

Now it’s fixed as per the below commit

「いいね！」 6
9

This topic was automatically closed after 32 hours. New replies are no longer allowed.

11

S3 CDN URL が投稿へのアップロード時に無視されるでの議論を続けます。

この問題は再発したようです。meta で再現できます。

image
image1222×505 78.4 KB

「いいね！」 3
12

@vinothkannans さん、@falco さん、これを確認してもらえますか？

「いいね！」 3
14

最近の変更により、アップロードされたファイルの URL は、初期のアップロードリクエスト自体から取得されるようになりました。以前は /uploads/lookup-urls.json エンドポイントから取得していました。このコミットで問題が解決するはずです。

「いいね！」 5
15

この修正は、プレビュー内のカスタム絵文字（例：:allthethings:）には適用されていないようです。

「いいね！」 4
16

これには、データエクスポートや単なるファイル添付のような添付ファイルも含まれていません。それらは依然として S3 から提供されます。

18

それなら直せます！

「いいね！」 3
S3 CDN URL not being used on non-image uploads