Thème Simple de Sam

[pmusaraj (Penar Musaraj)]

The category badges should be fixed now, too.

[Alex_P]

The color of unread topics is a bit hard to read:

Default theme:

This theme:

Probably need to un-hardcode this:
https://github.com/discourse/discourse-simple-theme/blob/ce745784e99f57d19cdff7411f102260f3add303/desktop/desktop.scss#L10

[Alex_P]

hm, looks like something is broken after recent update.

Now openning a topic from the list results in loading completely new page instead of just loading the topic with loading indicator etc. So it is a bit confusing because for a second it is unclear whether the click worked, and the editor window is lost, so it is difficult to add quotes from other topics etc.

[Johani (Joe)]

There was a bug related to this introduced a few days ago, but has since been fixed.

Can you please check if your site is on the latest?

/admin/upgrade

[Alex_P]

oh, cool

Yeah, it is not latest
2.7.0.beta8 ( f002c58a30 )

[Johani (Joe)]

The fix for the bug I mentioned was added a couple of days after your most recent upgrade. Can you please try upgrading again and let me know if the issue persists?

[Alex_P]

Yeah, seems to work fine after upgrade.

I wonder though why this issue was occurring only in this theme, others had this auto-route thing too but somehow were working fine.

[Alex_P]

@Alex_P

The color of unread topics is a bit hard to read:

Submitted a PR fixing this

Fix topic link color in dark mode

[jlzy]

Theme is significantly different in topic views since update… Please help!!!

[awesomerobot (Kris)]

can you be more specific about what has changed? do you have a screenshot?

[jlzy]

Yes, here is what it looked like before the update:

Now it looks like this:

[awesomerobot (Kris)]

hmm that’s strange… the theme works fine here on Meta…

I don’t see any console errors on your site… did you edit the theme at all? if you install another copy of it does it have the same issue?

[thisnthat]

A quick look shows that REFACTOR: Update structure, fix for ember-cli (#5) · discourse/discourse-simple-theme@0482a6c · GitHub may have changed the way that page is formatted on Aug 10th.

[awesomerobot (Kris)]

That refactored the theme structure, and fixed an issue with our ember-cli updates, but shouldn’t have changed anything about the layout (it’s also working as expected on our theme creator site: Discourse Theme Creator).

[thisnthat]

I found the problem, looks like those changes conflicted with a component that was in place which resulted int he changes to the displayed format.

Thank you

[Frully]

Je rencontre un problème similaire avec la mise à jour la plus récente - j’ai tout mis à jour en même temps, donc je ne sais pas si c’était le thème, un autre composant ou Discourse lui-même :
Discourse 2.8.0.beta8
10a57825c8

Thème mis à jour le 21 novembre (impossible de trouver le numéro de version) ‘à jour’.

Maintenant, lus et non lus s’affichent tous comme ‘non lus’ en bleu secondaire sur ordinateur, mais fonctionnent correctement sur mobile :
Ordinateur :

Mobile :

Même chose sur diverses itérations des schémas clair, moyen, foncé que nous avons créés… la mise en page principale à 2 colonnes ‘catégories+derniers’ semble correcte avec des sujets non lus en gras plus clairs et des sujets lus en gras atténué ; mais la liste ‘derniers’ est toujours en gras tertiaire.

L’utilisation de l’aperçu sur d’autres thèmes (par défaut et autres) semble montrer le comportement correct.

[Alex_P]

Avez-vous résolu ce problème ?
Pareil pour moi, tout est affiché comme non lu, les autres thèmes fonctionnent bien.

[Alex_P]

En examinant DevTools, il semble que cette règle de app/assets/stylesheets/common/base/_topic-list.scss disparaisse d’une manière ou d’une autre lors de l’utilisation de ce thème

[Alex_P]

ah, il semble que topic-list-data manque ici.

javascripts/discourse/templates/list/topic-list-item.hbr

PR soumis.

add topic-list-data class

[Frully]

Je ne l’avais pas fait - merci beaucoup d’avoir examiné cela