Selected text is overwritten when using the link toolbar action

Hello,

Since the latest github commits, it seems, there is something broken. Workaround:

By selecting a few words and trying to insert a hyperlink with the symbol bar icon, I’ve got a problem: The link I’ve copied before will overwrite the selected text, insted of filling the text field of the hyperlink prompt.

Result:
If I wrote more than just a few words and overwrite them, they will be lost for ever! I can’t undo this to restore my text. :sadpanda:

2개의 좋아요

Aha that does seem like a regression, but the temporary workaround is to not do that for now. How is this “urgent”?

I would say, the link prompt is one of the most important functions at our Discourse instance. Especially for mobile / tablet users.

Hello Markus,

I am able to understand the issue now. I am checking it. Thanks for reporting it.

3개의 좋아요

Thank you very much!!! :slight_smile:

Also as a workaround you can use “Paste as plain text” from context menu or Ctrl + Shift + V to skip HTML pasting.

3개의 좋아요

Thanks for the hint. :slight_smile:

Is it possible to generally disable HTML pasting? It seems to take much longer then before and won’t be kind of necessary / useful for us.

Maybe some kind of an integrated undo option inside the composer would be useful?

It is fixed now :+1:.

Currently there is no option to disable it. But you can always use the two workarounds above for plain text pasting.

4개의 좋아요

Can this be sped up @vinothkannans? Can there be a quick reject check where the code running sees that none of the special characters / data necessary for a fancy paste are present, and then it exits that code path to the traditional fast paste?

5개의 좋아요

It’s done. Now HTML to Markdown conversion happening silently in background. So no more waiting.

8개의 좋아요

I do like this a lot, I wonder though if long term we want to do this stuff in JavaScript both on server and client side. It just adds a tiny bit more polish to a wonderful feature.

Nothing urgent, something to think about longer term.

4개의 좋아요

Is this fixed now, or should still be open?

3개의 좋아요

Solved. Thanks guys! :heart:

3개의 좋아요