Shortcut to reply prints an "R" into the composer window

Looks like we’ve got a regression where hitting R to bring up the reply composer while viewing a post prints an “R” in the composer window, where it should be a blank composer. I can reproduce this on both meta and try.

Possibly due to the recent composer work, @nbianca ?

4 לייקים

In addition, it seems that reply to post via r is not working anymore, shift + r shows the above-mentioned behavior.

Reply to post also prints an r into the composer, but it works. Have you selected a post to reply to first via j and k?

4 לייקים

Ninja’d!

I also noticed that the same issue exists on the r shortcut, too

לייק 1

Thanks for pointing. I was unaware of that necessity, learning new Discourse features every day :nerd_face:

2 לייקים

Yep, without it Discourse doesn’t know which post you’re replying to :smiley:.

לייק 1

I thought it takes the one which is active in the address bar, e.g, 107202/4 or 107202/5 (it somehow already knows which post I’m looking at).

לייק 1

Might be ember3 , will look tomorrow

5 לייקים

Should be fixed by:

https://github.com/discourse/discourse/pull/6930

9 לייקים

We can’t do that based on the URL alone when there are multiple posts in the viewport, we can’t know which one you are replying to :wink:

4 לייקים

Somehow I knew that I was missing something :slight_smile: Thanks for the clarification!

לייק 1