Show on user card

[jomaxro (Joshua Rosenfeld)]

Feature request: Can the staff notes icon appear on the user profile card? Would be nice to be able to add/view a note from the latest view.

[codinghorror (Jeff Atwood)]

Probably a good idea for it to show somewhere on the user card.

[pfaffman (Jay Pfaffman)]

Just had an admin ask for this.

This should be doable now in a Theme, right?

[pfaffman (Jay Pfaffman)]

@codinghorror

Probably a good idea for it to show somewhere on the user card.

It’s three years later. Do you still think it’s a good idea to show a staff notes link (or some of the notes?) on the user card?

[sam (Sam Saffron)]

Maybe … the tricky thing is what would happen when you click the icon. Cause you don’t want absolutely position a window on top of another absolutely positioned window.

[pfaffman (Jay Pfaffman)]

@sam

the tricky thing is what would happen when you click the icon.

Oh. I think it’d just go do the user page (which it does anyway), I think that the idea is just making it easier to see that there are staff notes, and, perhaps, to add them to the user card if there is room.

[sam (Sam Saffron)]

Hmmm it does not take you to the user page now, it pops a modal:

Modal squared is not ideal. I guess adding the icon next to where the cakeday icon goes now is fine, and having it link to the user page with a tooltip.

Sure, I support that change.

[pfaffman (Jay Pfaffman)]

@sam

, it pops a modal:

Oops. Yeah. The double-modal is yucky. I guess that’s why he wanted such a change.

Could a theme component squeeze the staff note or the beginning of it, to the card?

@sam

Sure, I support that change.

Support as in #pr-welcome or support as in, someone will be on it next week.

[sam (Sam Saffron)]

@pfaffman

Support as in #pr-welcome or support as in, someone will be on it next week.

We will take this once we free up… some time in the next few weeks.

[vinothkannans (Vinoth Kannan)]

@sam

having it link to the user page with a tooltip.

It’s done.

https://github.com/discourse/discourse-staff-notes/commit/52338dd6eb837724b18e5850fd3355eae8a442ee

@sam

Cause you don’t want absolutely position a window on top of another absolutely positioned window.

I like to show the “staff notes” popup itself instead of redirecting. What if I closed the user card before opening staff notes popup? I’m able to do it like this.parentView.parentView._close()

[sam (Sam Saffron)]

@vinothkannans

I like to show the “staff notes” popup itself instead of redirecting. What if I closed the user card before opening staff notes popup? I’m able to do it like this.parentView.parentView._close()

I am not sure, @awesomerobot what do you recommend we do here?

[awesomerobot (Kris)]

Closing the usercard and opening the notes modal seems fine to me — I think it would be better than redirecting to the user page.

[vinothkannans (Vinoth Kannan)]

Done

https://github.com/discourse/discourse-staff-notes/commit/b5cb662802226fbe18ab60eb0c32e61c4add261e