Silenced user can circumvent it entering anonymous mode

pangbo · August 5, 2024, 1:02am

I think this issue could be fixed by adding
return if user.silenced? || user.suspended?
to

app/services/anonymous_shadow_creator.rb

2b577950a


      
            @user = user
          end
          
          def get_master
            return unless user
            return unless SiteSetting.allow_anonymous_posting
          
            user.master_user
          end
          
          def get
            return unless user
            return unless SiteSetting.allow_anonymous_posting
            return if !user.in_any_groups?(SiteSetting.anonymous_posting_allowed_groups_map)
            return if SiteSetting.must_approve_users? && !user.approved?
          
            shadow = user.shadow_user
          
            if shadow && (shadow.post_count + shadow.topic_count) > 0 && shadow.last_posted_at &&
                 shadow.last_posted_at < SiteSetting.anonymous_account_duration_minutes.minutes.ago
              shadow = nil

and

github.com/discourse/discourse

app/serializers/current_user_serializer.rb

2b577950a


      
          def can_post_anonymously
            SiteSetting.allow_anonymous_posting &&
              (is_anonymous || object.in_any_groups?(SiteSetting.anonymous_posting_allowed_groups_map))
          end

By the way, I am curious as to why the permission check for can_post_anonymously is not implemented within the Guardian module.

Topic		Replies	Views
Anonymous mode not working Bug anonymous-mode	7	751	August 9, 2020
Enable and configure anonymous mode Site Management how-to , anonymous-mode	0	8295	June 23, 2020
Anonymous posting not available even when enabled Support anonymous-mode	7	2809	June 23, 2020
Anonymous posting -- but retaining original user permissions Feature anonymous-mode	11	1937	December 2, 2021
Anonymous posting for sensitive subjects Feature anonymous-mode	16	2048	June 13, 2020

Silenced user can circumvent it entering anonymous mode

Related topics