Right, this was what I was trying to get at by proposing putting this behind a global pref, thanks for putting it more clearly.
I hadn’t considered that even within Mozilla there may be people who want to use email as a “trigger”, rather than for interaction - so a user preference makes more sense. We’d probably be wanting to set it to “MAILMAN foreva ™” mode by default, though
This is required, I can’t see a way of managing to change the template used from a plugin without doing something horrific like monkey patching
And I think it makes sense to place these custom templates in a plugin - it allows individual Discourse instances to use whatever custom templates they want.
But I’m not sure between those two points what should be in core, and what should live in a plugin. Would you see this extensibility in core take care of the user preferences side of things, simply enabling a plugin to specify a template and name?
Or would you see the piece in core being more general, allowing any plugin to override any template, with this specific plugin hooking into that and handling the user preferences side? How would we decide, in core, which plugin gets the final say on what template gets rendered?