Small error in the console after clicking inside a loaded video

[Arkshine]

Related to:

• DEV: Prevent videos from preloading metadata by oblakeerickson · Pull Request #23807 · discourse/discourse · GitHub
• DEV: Show a loading spinner on video placeholders by oblakeerickson · Pull Request #24039 · discourse/discourse · GitHub

Here is a small video showing the issue:

It looks like removing the click listener here doesn’t work. The next time a click happens, the video-placeholder-container doesn’t exist anymore:

https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/app/instance-initializers/video-placeholder.js#L16

Probably because of bind usage here:

https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/app/instance-initializers/video-placeholder.js#L85

Maybe an easy solution would be to use { once: true } in addEventListener instead?

[Arkshine]

Thanks for the fix @blake!

DEV: Use click once for video place holder

[blake (Blake Erickson)]

My pleasure! Thank you for reporting it and for the suggestion