로드된 비디오 내부 클릭 시 콘솔에 작은 오류 발생

[Arkshine]

Related to:

• https://github.com/discourse/discourse/pull/23807
• DEV: Show a loading spinner on video placeholders by oblakeerickson · Pull Request #24039 · discourse/discourse · GitHub

Here is a small video showing the issue:

It looks like removing the click listener here doesn’t work. The next time a click happens, the video-placeholder-container doesn’t exist anymore:

https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/app/instance-initializers/video-placeholder.js#L16

Probably because of bind usage here:

https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/app/instance-initializers/video-placeholder.js#L85

Maybe an easy solution would be to use { once: true } in addEventListener instead?

[Arkshine]

Thanks for the fix @blake!

https://github.com/discourse/discourse/pull/24141

[blake (Blake Erickson)]

My pleasure! Thank you for reporting it and for the suggestion