What should be between the parentheses in this message?
I’m on Discourse v1.5.0.beta2 +83. Chrome 46 on Windows.
AI-generated summary
A discussion was started by dandv regarding the “Select images or files from your device ()” message, where the parentheses were empty. Mittineague pointed out that clicking the upload icon reveals the approved file types. However, dandv noted that their extensions were set to *, and the parentheses should either display * or be hidden.
codinghorror agreed it was a small bug and suggested hiding the parentheses if all file types are specified. They also mentioned that specifying all file types can be dangerous. dandv expressed concerns about blacklisting certain file types, such as .exe, and suggested displaying a help text in the dialog to advise users to zip files with unsupported extensions.
The issue was eventually fixed by zogstrip, who committed the changes to GitHub.
Click the upload icon in the composer menu here and you’ll see the approved file types
select images or files from your device (.jpg, .jpeg, .png, .gif, .svg, .txt, .ico, .yml, .csv, mp3, json)
1개의 좋아요
Looks like a small bug then. I have my extensions set to *:
Shouldn’t * appear between the parens, or perhaps no parens at all?
Yep small bug for @zogstrip to look at. I would just hide the () part if they specified all file types. (by the way this is very dangerous)
I’d love to blacklist .exe, but that doesn’t seem possible? Users of my forum upload all sorts of custom file formats from various self-tracking apps, and having an inclusive list failed every time someone came up with some data dump from a new app.
Maybe an alternative would be for Discourse to display a short help text in that dialog along the lines of “Please zip any file with an extension not in this list”.
Here’s the fix 
https://github.com/discourse/discourse/commit/0ea54e9255d7111ffd18bc9fe052831f641ee614
4개의 좋아요