Staged users' posts stuck in queue

I have been running my site for over a year now and this just started happening lately.
We have many staged users as the site mostly functions as a help desk / ticket hub.

Within the last week or so tickets with embedded media (screenshots) have been stuck in the approval queue.

When I checked the “skip review media groups” TL0 is there, but I’m guessing staged users might have a slightly different flag.

This needs to be fixed as folks are missing tickets. Why did this just now start?

Thanks!
David

I feel like this might be a report about the same problem

I think staged users were immune to most limits. That’s why they had the separate Approve unless staged site setting. But I haven’t used that feature so I am not sure.

Which reason is shown in the review queue?

I don’t have one in review right now, but it was referring to the fact that there were embedded media in the posts each time.

I checked that setting for Approve unless staged, and it’s not checked.

You should be able to see prior ones by changing the status filter at the top.

I will try to take a look. But I can’t say when I’ll get around to it. I hope someone else will step up.

Oh, I see.

This post includes embedded media. See skip review media groups.

And that setting includes admins, moderators, trust_level_0

I"m still getting these. Is there anything I can do to fix it?
It’s really impacting our workflow.

Sorry I haven’t had time to take a look yet. If it’s that important to you, you should consider asking for help on Marketplace.

I think it’s related to the changes in Incoming emails with signatures/tables/inline images rejected with “Access Denied” - #2 by Ethsim2. So maybe @Ethsim2 has an idea

No apology necessary. Free help is free help. I was just reaching out to give you a full screenshot.

You should have just as easily said, “Hold your horses, fix incoming when I get to it!”

:slight_smile:

I tested this on a current self-hosted instance.

Staged users are not members of trust_level_0, so having trust_level_0 in skip review media groups does not exempt them.

However, adding logged_in_users to skip review media groups does.

I tested this both directly against NewPostManager and through the real email-in path. An email from a newly-created staged user containing embedded media was posted immediately instead of going to the review queue.

So for a helpdesk-style setup where arbitrary new senders are created as staged users, adding logged_in_users appears to provide the intended behaviour without needing to activate the users or maintain a separate group.

One slightly surprising detail is that staged users match the logged_in_users pseudo-group for this check even though they are not activated/logged-in accounts in the usual sense.

I’ve also opened a PR to add regression coverage for this behavior:

It verifies that a newly-created staged user with embedded media is not queued when logged_in_users is included in skip_review_media_groups.

This should also clarify whether maintainers consider staged users matching logged_in_users here to be intended behavior that we can rely on going forward.