Strip trailing spaces from login email

ky_metro · 12월 9, 2015, 11:51오후

Mobile keyboards tend to add spaces when auto-completing words. We don’t strip trailing spaces from email addresses on the login screen. I’ve had users trying to log in on mobile run into this, it returns "no account matches xyz@mail.com", for an account that does exist.

They are stripped from the invite form already. We should strip them on login too.

codinghorror · 12월 9, 2015, 11:52오후

Agreed @techapj can you take this? Anywhere the user can input data on signup (or login) we should be stripping leading and trailing spaces either during or prior to submission.

watchmanmonitor · 12월 10, 2015, 4:43오전

I’m forever copying email addresses in some manner that has a leading space.. will be glad to see this managed!

techAPJ · 12월 10, 2015, 8:30오전

We does strip the the leading/trailing spaces from username/email via:

github.com/discourse/discourse

app/controllers/session_controller.rb

master


      
              log_on_user(user)
          
              if params[:redirect] == "false"
                render plain: "Signed in to #{params[:session_id]} successfully"
              else
                redirect_to path("/")
              end
            end
          end
          
          if Rails.env.test?
            skip_before_action :check_xhr, only: :test_second_factor_restricted_route
          
            def test_second_factor_restricted_route
              target_user = User.find_by_username(params[:username]) || current_user
              raise "user required" if !target_user
              result =
                run_second_factor!(TestSecondFactorAction, target_user: target_user) do |manager|
                  manager.allow_backup_codes! if params[:allow_backup_codes]
                end
              if result.no_second_factors_enabled?

I am not able to repro the issue (on Desktop/Mobile) where leading/trailing spaces causes login error.

codinghorror · 12월 10, 2015, 8:35오전

Is this true for password reset form as well, though?

techAPJ · 12월 10, 2015, 8:39오전

Good catch! Not true in case of password reset, fixing now.

(Sign up form strips whitespace, checked earlier)

techAPJ · 12월 10, 2015, 9:08오전

Fixed via:

https://github.com/discourse/discourse/commit/335e79777659f543d02d7f027b033b966d3bc866

OOPS: ~~trip~~ trim

글		댓글	조회수
'Send Invite' button greyed-out and inoperative if there is a trailing space after the email address Bug	2	1276	5월 16, 2015
Trim search keyword in User Search / Admin Panel UX	1	902	10월 10, 2016
"Invalid" email address disables "send email" button on invite without message UX pr-welcome	2	834	3월 7, 2023
Import phpBB - incomplete due to user invalid email address (trailing space) Migration phpbb	2	124	12월 12, 2024
Leading/trailing spaces cause errors when importing themes Bug	2	576	12월 13, 2018

Strip trailing spaces from login email

Related topics