부정확한 링크 카운터 값 수정 제안

Further to what I thought was a bug but is seemingly by design, the topic link counter stops at 50:

Even if there are thousands of links in the topic :pensive_face:

And:

With this in mind, rather than showing an inaccurate number to the end user could we simply display a + symbol if there are more than 50 links in a topic?

For example, this:

Would simply become 50+ like so:

This way the user is not being told inaccurate information :thinking:

7개의 좋아요

@lindsey do you feel this is pr-welcome? Seems like a small and easy change (we would over select by 1 and then use that information to decide if we render 50 or 50+)

3개의 좋아요

Agreed, added a pr-welcome to add the + for accuracy.

2개의 좋아요

Thanks @lindsey :grin:

I gave it a try:

https://github.com/discourse/discourse/pull/32093/files

6개의 좋아요

Wow, that was quick!

Thanks @Arkshine :smiley:

1개의 좋아요

Hey, I have a question: From what I have seen, all the other components, like views and likes, have the full number. For the sake of design consistency, we should either add the plus to the other cases or add the full number to the link count.

1개의 좋아요

Is there a process for getting this PR merged @Arkshine ? :thinking:

1개의 좋아요

An approved PR is not necessarily merged immediately. There might be some internal concern or discussion about it. Since it’s low priority, let’s wait!

1개의 좋아요

Ok, thanks, just wasn’t sure what the process was :slight_smile:

1개의 좋아요

It is merged now, thanks @Arkshine

3개의 좋아요

Thanks again for working on this one @Arkshine :partying_face:

2개의 좋아요