Suggestion regarding the box-shadow of the Dark Theme composer

Contribute UX
1

This could just be an individual taste situation, but I noticed that the composer has a “white glow” when using the Dark Theme. It’s especially apparent when hiding the preview in the composer. I changed mine to a darker shadow and liked the result. Below is a comparison:

Default

31 AM
31 AM1796×752 48.7 KB

Modified

15 AM
15 AM1826×750 48 KB

Here’s the change I made to the Dark Theme Desktop CSS:

div#reply-control {
   box-shadow: 0 -2px 10px rgba(0, 0, 0, 1);
}

This is a super nit-picky thing, but on the off chance anyone else felt the same way, I thought I’d share my solution :slightly_smiling_face:

7개의 좋아요
2

Interesting, what do you think @awesomerobot?

3

This makes sense. It looks like most of our box-shadows are defaulted to be black no matter the theme (see the header for example), so we should do that on the composer too.

8개의 좋아요
4

Did we update this for the dark theme?

5

Yes, that was fixed here

https://github.com/discourse/discourse/commit/73912ebc1223bf13d23ff0cfeb515e57ef2a6b18#diff-c3730d05192b6961c9a63d0672253b68

and further improved later here

https://github.com/discourse/discourse/commit/677e126fbf5d681ef1666b119333b0a89480ba31#diff-c3730d05192b6961c9a63d0672253b68

6개의 좋아요