"Suppress these tags from summary emails" settings is not working in preview digest email?

Contribute Bug
1

I excluded some tags in the new settings and try to preview the digest email, the preview contains some duplicated topics, and topics with those tags are also included.

2 Likes
2

Testing this on my local dev site, it seems to be a bug. The code is expecting the digest_suppress_tags setting to be a pipe delineated list of tag ids, but it’s actually a list of tag names:

Here’s what the setting looks like on my site:

SiteSetting.digest_suppress_tags
=> "foo|bar"

The code that’s excluding the tags from the digest is expecting the setting’s value to be "1|2" (the tag ids.)

Note that the digest_suppress_categories setting works without any issue. The settings category-selector saves category ids, not category names.

3 Likes
5

This is now fixed in:

https://github.com/discourse/discourse/commit/83621ccbe797223b48b624b00ef04f24672e1f03

Thank you for the report @th21 and for the great analysis/debugging @simon!

4 Likes