Tag changes persist throughout entire edit history

[erlend_sh (Erlend Sogge Heggen)]

@neil I don’t think this should be happening:

See the “tags changed: votes-friendly → votes-friendly”

This change is noted on every page of the post’s history.

It also seems like when a new tag is added we say “tagX → taxX” instead of saying “tagX was added”.

[cpradio]

I think this is related

Post edit tracker missing tags changed

Likely something for @neil related to the recent migration of #tagging::tag into core. Noticed recently over at Stonehearth that not all tag changes appear in the post edit history. Here is one example: Tags are restricted to TL4 only, so the user didn’t attach any tags on post creation. I am pretty sure that 8bitcrab added a tag on March 30, followed by Albert on March 31, but Albert’s tag doesn’t appear. I can provide more examples if needed, hopefully this is enough.

As if the last tag change or maybe the first (who knows) is persisting across all entries, it seems to me that would explain why the post edit history doesn’t show all of the tag changes that have occurred on said topic.

[codinghorror (Jeff Atwood)]

Did we resolve this @neil?

[jomaxro (Joshua Rosenfeld)]

Still happening:

Error while trying to edit a post or change ownership of it

I’ll have a look at this today. This is happening because we are now raising an error instead of silently ignoring it in the past when topic links fail to be created.

[neil (Neil Lalonde)]

I just pushed a fix for this one. The data is correct, but the UI was displaying it wrong.