Tagging on mobile isn’t working

סיכום מבוסס בינה מלאכותית

The discussion revolves around the issue of tagging not working on mobile devices. ChrisBeach reported the problem, stating that the keyboard doesn’t pop up and the drop-down menu is too wide to show any tags on his iPhone X with iOS 11 and Safari.

joffreyjaffeux responded that tagging was previously disabled on mobile but is working on a fix. He later provided a GitHub commit https://github.com/discourse/discourse/commit/a15b2fdecaa2cb9da3e172ca795ac385bbd7a063 that should make it possible to edit tags on mobile, which ChrisBeach confirmed fixed the issue.

However, ChrisBeach also requested the restoration of the keyboard pop-up behavior when tapping the tag entry field, which joffreyjaffeux agreed to improve. joffreyjaffeux later provided another GitHub commit https://github.com/discourse/discourse/commit/057fa049e674b4a0b222e51578511abe30b3ebfa that should fix the keyboard pop-up issue.

When trying to add a tag, I find that the keyboard doesn’t pop up, and the drop-down is too wide for the screen so doesn’t show any tags:

iOS 11, Safari, iPhone X

לייק 1

AFAIK tagging was disabled on mobile but didn’t check it was the case for this one (composer is certainly disabled).

Anyways, I will try to make it work on mobile. This one is not in the composer so I should be able to have something working.

4 לייקים

Thanks @j.jaffeux - it’s very important to me that tagging works on mobile (it has been working for months/years until I updated the site yesterday)

https://github.com/discourse/discourse/commit/a15b2fdecaa2cb9da3e172ca795ac385bbd7a063

should make it possible to edit tags when editing a topic. I will improve it more in the next days but it should at least fix your current issue.

7 לייקים

That’s fixed mobile tagging for me, thanks @j.jaffeux!

Just one other thing - I think the keyboard used to pop up when tapping the tag entry field. This was useful because there are hundreds of tags on my site so searching is an inevitability.

Could the keyboard pop-up behaviour be restored please?

לייק 1

yes that’s one of the things I want to improve.select-kit has been very defensive on auto focus at the beginning on mobile, but I think I can open it on few components safely now.

5 לייקים

Should be fixed by:

https://github.com/discourse/discourse/commit/057fa049e674b4a0b222e51578511abe30b3ebfa

7 לייקים