Página de tags mostrando tags sem tópicos visíveis

## What is the problem here? Currently, `Tag#topic_count` is a count of all …regular topics regardless of whether the topic is in a read restricted category or not. As a result, any users can technically poll a sensitive tag to determine if a new topic is created in a category which the user has not excess to. We classify this as a minor leak in sensitive information. ## What does this PR change? 1. Introduce `Tag#public_topic_count` which only count topics which have been tagged with a given tag in public categories. 2. Rename `Tag#topic_count` to `Tag#staff_topic_count` which counts the same way as `Tag#topic_count`. In other words, it counts all topics tagged with a given tag regardless of the category the topic is in. The rename is also done so that we indicate that this column contains sensitive information. 3. Change all previous spots which relied on `Topic#topic_count` to rely on `Tag.topic_column_count(guardian)` which will return the right "topic count" column to use based on the current scope. 4. Introduce `SiteSetting.include_secure_categories_in_tag_counts` site setting to allow site administrators to always display the tag topics count using `Tag#staff_topic_count` instead. ## Notes for reviewer 1. It is easier to follow this PR if you follow the commits in the order they were made. 1. This was discussed internally and our objective here is not to display the count as accurately as possible. Making the count accurate for all users is complicated to do and we're not ready to make that investment at this point in time.

JammyDodger · Fevereiro 6, 2023, 8:00am

Este tópico foi fechado automaticamente após 4 dias. Novas respostas não são mais permitidas.

Tópico		Respostas	Visualizações
Accurate topic count in tag list Feature	11	1160	26 de Agosto de 2020
Incorrect Count on /tags page (included deleted topics - now fixed) Bug	13	2507	28 de Agosto de 2017
Tag pages show only 10 entries Support	10	1328	9 de Maio de 2019
Unlisted topics are included in the Tag (topic) count for normal users who don't actually see those topics Feature unlisting	5	1247	20 de Fevereiro de 2016
Plugin - Get unseen topic count per tag Dev	4	849	29 de Setembro de 2017

Página de tags mostrando tags sem tópicos visíveis

Tópicos relacionados