Text color issue in Category menu

AI-generated summary

Users reported a text color issue in the Category menu where text remains black or dark gray against darker category backgrounds, making it unreadable. This issue was confirmed on version 2.5.0.beta6 by multiple users, including adamengst, simon, bidouilleur, and Stephen, while it was not present in beta5. The problem appears to be new in the latest beta and affects both self-hosted and hosted installations. codinghorror flagged it for attention, and awesomerobot confirmed the fix, which was committed to the codebase and expected to be available in updates later the same day for users on the default tests-passed branch. craigconstantine praised the team for the quick resolution, noting the improved appearance of categories with the fix. The issue was specifically related to text color not adapting to background color in category boxes, unlike other parts of the interface where text color is appropriately reversed for contrast.

In the Category menu, when using the style that has colored boxes, the text is always black (or dark gray), which renders it unreadable against darker category colors. Everywhere else, the text is appropriately reversed so dark boxes get white text.

2 likes

I can reproduce this issue in my dev environment that’s running version 2.5.0.beta6, but not on my hosted site that’s on version 2.5.0.beta5.

I’m seeing it on both my self-hosted installations of 2.5.0beta6 but can’t check an older install. So maybe it’s new in the latest beta.

We also have the issue on a hosted version 2.5.0B6.
Some users have complained.
Hopefully next release will solve it

Also experiencing this - seems to force text to white for dark themes and black for light themes, regardless of the secondary color set for the subcategory.

Maybe one for next week @awesomerobot?

1 like

Fixed it here, should be included in updates later today (if you’re on the default tests-passed branch).
https://github.com/discourse/discourse/commit/fbeaba4acf2f613b4910d331f2a01d39a7ef3463

6 likes

Just want to say, nice fix on this team! The new unified styling in menus looks great and with this fix my categories look spiff too. :smiley:

3 likes