The PR added an animation to the new topic alert. It seems good overall but it accidentally break the original align mechanism.
The root cause behind it is that transform: translateX(50%); failed to work with the new animation css animation: float-down 250ms ease-in-out forwards; When the animation is activated, the original transform turns invalid.
The bug can be seen from the attached file.
1개의 좋아요
Since transform and the float-down animation are conflict themselves, I think there are two ways to solve that:
- Adding a new animation class
float-down-center to dicourse.scss, including the transform: translateX(50%); to the keyframe.
- Changing the way the button is aligned without using the tranform attribute, using
width: fit-contenet, left: 0, right: 0 and margin: auto;
If that is the case, I’ll raise a PR to fix that.
1개의 좋아요
@jordan.vidrine i thought i noticed this too
Have a small fix in for this, will merge soon.
2개의 좋아요
Merged your PR instead. Thanks!
1개의 좋아요