Don
10 בפברואר, 2023, 4:48pm
1
Hello,
Thanks for the component
I have noticed a little issue with it. It seems on mobile (I tested on Android 10 Chrome 109.0.5414.117 and iOS 16.1.1 Safari) it only scrollable if the sidebar is scrollable. When the sidebar sections are collapsed the theme toggle is not scrollable for me. Thank you
3 לייקים
Canapin
(Coin-coin le Canapin)
7 במרץ, 2023, 10:43am
2
Is it still the case? I can’t repro on my android phone.
לייק 1
Moin
7 במרץ, 2023, 11:13am
3
I can. I cannot scroll if all sections are collapsed
If the sidebar is scrollable, the menu to choose a theme is too
4 לייקים
Canapin
(Coin-coin le Canapin)
7 במרץ, 2023, 12:08pm
4
I misunderstood the issue and I after trying again, I experience it as well.
2 לייקים
I’ve added a fix here:
discourse:main
← discourse:fix-scroll
opened 05:37PM - 07 Mar 23 UTC
Issue discussed here: https://meta.discourse.org/t/sidebar-theme-toggle/242802/1… 5?u=awesomerobot
When the sidebar sections are collapsed on mobile and the sidebar itself isn't scrollable, the theme dropdown will not scroll either. I've added a slight hack to ensure the theme dropdown is always scrollable, this seems to have no impact on the main scrollbar's scroll behavior.
I’ve updated the component on Meta, and it works fine for me on mobile now! Thanks for reporting it everyone!
4 לייקים