The theme selector can't be scrolled when sections are collapsed

기여 버그
1

Hello,

Thanks for the component :slightly_smiling_face:

I have noticed a little issue with it. It seems on mobile (I tested on Android 10 Chrome 109.0.5414.117 and iOS 16.1.1 Safari) it only scrollable if the sidebar is scrollable. When the sidebar sections are collapsed the theme toggle is not scrollable for me. Thank you :slightly_smiling_face:

3개의 좋아요
2

Is it still the case? I can’t repro on my android phone.

Screenshot_20230307_114304_com.android.chrome
Screenshot_20230307_114304_com.android.chrome1080×2240 155 KB

1개의 좋아요
3

I can. I cannot scroll if all sections are collapsed

_20230307_121118
_20230307_121118720×916 37.3 KB

If the sidebar is scrollable, the menu to choose a theme is too

_20230307_121217
_20230307_121217720×924 44.7 KB

4개의 좋아요
4

I misunderstood the issue and I after trying again, I experience it as well.

2개의 좋아요
5

I’ve added a fix here:

https://github.com/discourse/discourse-sidebar-theme-toggle/pull/4

I’ve updated the component on Meta, and it works fine for me on mobile now! Thanks for reporting it everyone!

4개의 좋아요