إبهامان للأعلى

nat · 28 أكتوبر 2022، 11:36ص

أصلح هنا. يجب أن يكون قريباً!

github.com/discourse/discourse

FIX: Evaluate all callbacks rather than override them

main ← multiple-post-menu-button-callbacks

opened 11:32AM - 28 Oct 22 UTC

nattsw

+30 -23

When we have multiple plugins triggering ``` api.removePostMenuButton("like"…, () => x); ``` the last plugin that makes the call gets to decide if the post menu button is removed or not. This change makes it such that we will evaluate all callbacks rather than just rely on the last one. Essentially, we ended up with duplicate like buttons when the discourse-upvotes plugin evaluates after discourse-reactions. <img width="354" alt="Screenshot 2022-10-28 at 7 33 19 PM" src="https://user-images.githubusercontent.com/1555215/198577684-add9e90d-7523-4595-8680-216add1cfe84.png"> Related: https://meta.discourse.org/t/thumbs-up-twice/240867/

الموضوع		الردود	مرات العرض
Changes to which reactions :thumbsup: are counted as likes :heart: Announcements reactions	46	3204	27 مايو 2024
Notice: testing Discourse Reactions here on meta for 1 week! Feature	85	8766	14 أبريل 2021
Discourse Reactions Plugin official , reactions , included-in-core	66	42328	5 أكتوبر 2026
Thumbs-up - three names, one emoji UX reactions	12	1624	11 سبتمبر 2023
Post Voting has likes enabled but they won't appear Bug reactions , post-voting	9	1313	10 أغسطس 2023

إبهامان للأعلى

الموضوعات ذات الصلة