Zeemah
14. Dezember 2018 um 22:10
1
Aktuell können Benutzer mit Trust Level 4 oder der Rolle „Leader" einen Beitrag, den sie versteckt nicht gelistet haben, nicht mehr einsehen, es sei denn, sie besitzen einen Link. Ich finde, sie sollten in der Lage sein, entweder:
Alle versteckten nicht gelisteten BeiträgeSelbstversteckte nicht gelistete Beiträge
Die einzige Möglichkeit, diese Beiträge einzusehen, besteht darin, entweder einen Link zu haben oder ihre Kontoaktivitäten aufzurufen.
What do you mean by hidden? Do you mean an unlisted topic?
Moin
29. Mai 2024 um 18:15
4
So wurde es implementiert
main ← Drenmi:feature/tl4-users-list-unlisted-topics
opened 06:50AM - 17 Jan 23 UTC
### What is this change?
In response to [this Meta topic](https://meta.discou… rse.org/t/allow-tl4-or-cat-mod-to-see-unlisted-topics-in-topic-list/245069).
TL4 users can already list and unlist topics, but can not see topics that have been unlisted. This change brings that back to par by giving TL4 users the ability to see unlisted topics as well.
(This could technically be considered a fix, but it's a bit unclear, and so I labelled it as feature to highlight the change in behaviour.)
### What's the approach?
I've added a new `TopicGuardian#can_see_unlisted_topics?` which grants permission to staff and TL4 users. This encodes the fact that staff users can see unlisted posts explicitly. This was previously implicit in the `TopicQuery` code. (See inline comment for more details.)
### What else was considered?
It originally looked to me as though this could be yet another alias of `#can_perform_action_available_to_group_moderators?`, which is used as a shared check for a number of actions, such as archiving, pinning/unpinning, opening/closing, etc.
However, as I went down this route, I encountered more and more friction stemming from the fact that all the other actions are operations on a particular topic. The end result was that the `#can_perform_action_available_to_group_moderators?` lost its conceptual clarity, and so I decided on a separate method instead.
### Manual verification
- [x] Staff can still see unlisted topics.
- [x] Users can still see unlisted topics _when viewing their own topics_.
- [x] Users can not see unlisted topics under other filters.
- [x] TL4 users can now see unlisted topics.
1 „Gefällt mir“