Topic actions on mobile cut off after updating

AI-generated summary

The discussion is about an issue with the topic actions on mobile devices after updating. ondrej reported that the menu is cut off on the right side and there is no close button, and also mentioned that the “Add User Note” option is separated from the rest of the menu. codinghorror referred the issue to joffreyjaffeux, who fixed the “Add User Note” issue and acknowledged the other issues, but couldn’t reproduce them initially.

After ondrej provided more context that the issue is on mobile devices, joffreyjaffeux confirmed that the close button (x) is intentionally removed. ondrej tried in safe mode, and joffreyjaffeux identified the issue on small mobile screens.

joffreyjaffeux fixed the issue with a commit to the Discourse repository and shared a screenshot of the fix. ondrej thanked joffreyjaffeux for resolving the issue.

Hello,
After updating I was met with these options. I like the look of them as they seem very sleek and modern. However, I guess there is not meant to be a close menu button as you can click somewhere on the screen to click off. The menu is too much to the right as there is a gap on the left.



Also the add user note is separated on the post admin menu. Is this because it is a plugin separate to what is meant to be on the menu?


Finally, the make wiki is way too long as it overlays the post count on the bottom right


Thanks :blush:

This is still a little in flux, check with the ineffable @j.jaffeux for details

3 Likes

If you pull latest version of the plugin this is fixed.

Can’t repro this, give me more context please. And also I don’t see this issue with this, this is a popover menu, this is meant to be over other elements of the UI.

Can’t repro this, give me more context please.

3 Likes

Hey,

Thanks for replying. (I should have mentioned that this is on mobile)

Before we updated it had a x

Now it is like this without a x Additionally, I added a red semi circle to where it is cut off

Yes the x is gone, no plan to have it back ATM.

Are you using some custom css for this menu ? It’s not supposed to display on two columns.

2 Likes

Ahh, OK thanks for clarification on that :smiling_face_with_sunglasses:

Just tried in safe mode and it still happens

Oh ok I see this for small mobile screens. Will fix it :+1:

3 Likes

Thanks so much Joffrey! :blush:

1 Like

That should be fixed by:

https://github.com/discourse/discourse/commit/93bd1ff228d471a6f48537f64f9cb328e26951c2

Thanks :+1:

@awesomerobot note that I removed border-bottom in this case, I think it doesn’t make sense when we show multiple actions per row. Feel free to change if you disagree :stuck_out_tongue:

4 Likes

Thanks again! :grinning_face:

1 Like