While managing report descriptions, I found a bug: disabling any description (except “Send message to @%{username}”) causes other report descriptions I created to be hidden.
Before disabling:
After disabling:
2개의 좋아요
Sorry about that, issue should be fixed by
main ← fix-flag-name-key-uniqueness
merged 02:37PM - 24 Jun 26 UTC
Previously, flag names with no ASCII word characters (e.g. Chinese) all normaliz… ed to the same `name_key` of `custom_`, because `set_name_key` stripped non-`\w` characters and Ruby's `\w` is ASCII-only. The flag system keys lookups by `name_key` (the `disabled_flag_types` enum, the frontend `actionByName` map), so once two flags shared a key, disabling one of them flipped `can_act` for the whole group and hid every other flag that shared it.
This makes `name_key` reliably unique:
- `set_name_key` falls back to `custom_flag` when the slug is empty and appends a counter (`_2`, `_3`, ...) on collision, so distinct names always produce distinct keys. It now only re-derives the key when the name actually changes, keeping it stable across other saves.
- A post-deploy migration backfills existing duplicate keys and adds the unique index on `flags.name_key` that the original `create_flags` migration intended (`unique: true` is a no-op in `create_table`).
https://meta.discourse.org/t/405254
2개의 좋아요
It seems like the bug hasn’t been fixed yet. After I updated, the bug was still there.
That’s because the PR hasn’t been merged yet
Heads up @AkarinLiu - the PR has now been merged
