I’ve got two plugins that are failing travis tests. It appears that I don’t have any es6 files in them and eslint feels left out? Running linters/prettyfiers eslint yarn run v1.22.5 $ /var/www/discourse/node_modules/.bin/eslint -v v6.8.0 Done in 0.32s. prettier yarn run v1.22.5 $ /var/www/discourse…

Yes, eslint doesn’t like having nothing to do. This makes it feel more useful. mkdir -p assets/javascripts/discourse touch assets/javascripts/discourse/eslint.js.es6 git add assets/javascripts/discourse/eslint.js.es6 git commit -m 'try to make eslint not feel left out' git push Oh, but I think thi…

Ah, but how are you going to PR that without eslint complaining? :wink:

I understand so little of what’s going on here that I almost didn’t get your joke!

Yes I pushed this fix for github actions the other day: DEV: fixes eslint/prettier on github actions (#10601) committed 06:01PM - 04 Sep 20 UTC (UTC) [image] jjaffeux …

That should fix it: FIX: prevents eslint failure on unmatched patterns in plugins (#10648) committed 06:17PM - 10 Sep 20 UTC (UTC) [image] jjaffeux +2 …

Travis CI Travis CI enables your team to test and ship your apps with confidence. Easily sync your projects with Travis CI and you'll be testing your code in minutes. 2 files inspected, no offenses detected [2020-09-10 18:43:13] bundle exec ruby script/i18n_…

Oh right yes it’s using discourse-plugin-ci stuff, if you read at the code you will see: script.sh master echo "travis_fold:start:starting_docker_container" [ -d './test' ] || export RUBY_ONLY=1 [ -d './spec' ] || export JS_ONLY=1 …

Travis tests failing due to eslint

Development

j.jaffeux (Joffrey Jaffeux) September 10, 2020, 6:18pm 6

That should fix it:

Let me know how it goes

Topic		Replies	Views
Trouble with eslint since recent change to plugin-skeleton because failed to run yarn install Development	0	486	November 29, 2023
Trouble with eslint Development	7	2500	July 30, 2024
Code linting and formatting with prettier Development	6	2544	July 24, 2018
Linting consistency Development	10	169	January 1, 2026
Linting configuration Development development	5	213	September 11, 2024

Travis tests failing due to eslint

Related topics