It stills working?
I tried to use it with based air-theme and I got the login into FAQ (not /login). What can be wrong?
I suspect that’s something related to my installation but I don’t know how to look into.
AI-generated summary
The discussion revolves around the “Trendy Login” theme component, which was causing users to be redirected to FAQs instead of the login page, particularly with the Air theme. satonotdead reported the issue, suspecting it was installation-related. Heliosurge confirmed it worked for them but noted it disables site viewing without login. tobiaseigen explained the component conflicts with a recent core change that makes private sites more welcoming by default, recommending against its use unless custom login text is needed. david suggested auto-disabling the component on newer Discourse versions. tobiaseigen acknowledged some users may still prefer it for flexibility. satonotdead criticized the modal’s outdated UI/UX, urging Discourse to improve core experiences like login and chat. tobiaseigen clarified the component is customizable and noted the roadmap includes moving away from modals. meghna submitted a PR to update the component for compatibility, removing some settings but retaining background and description customization, sharing screenshots of the improved look. tobiaseigen praised the update but noted it displayed both site description and login subheader text redundantly. meghna promptly fixed this issue in a commit, ensuring only the login subheader field is shown.
2 Likes
It was working for me on Air Theme. But disabled it as didn’t read the Op properly and didn’t realize it closes the view site without login
Try it with defaults and maybe try preview as it runs component without others active.
1 Like
I just did a test and see the component still works but it conflicts with a new core change. Now private sites are more welcoming by default. With trendy login you get potentially duplicative information.
I would recommend not using trendy now that we have this change in core. Just edit your site description.
4 Likes
Should we update this component to auto-disable itself on latest Discourse, and mark this topic as broken?
5 Likes
Yeah, I had that thought. But some people might prefer trendy because it can provide more flexibility in the info you show people before they log in.
4 Likes
Modals are totally out of the actual UI/UX standarts and the same applies for non-rounded buttons and/or animations on hover, for mention some things little outdated =)
That’s not a very big deal when the communities are related to devs but some of us are working with people (we love devs and people too) and I think that’s explains why Flarum exists, like a beauty or polished copy of Discourse and no more else.
I hope Discourse can give a look -and a couple of bucks- to improve at least the most used escenarios of our websites like login, PMs, chat and discussions
This is a theme component so you are free to design it as you see fit for your site.
The new login screen in core already has a cleaner design, so no theme component is needed in fact unless you want to have different text from the site description on your login screen.
Moving away from the modal is already in the roadmap and will be coming at some point in the not too distant future.
5 Likes
I just updated the component to make it compatible with latest Discourse version via this PR:
https://github.com/discourse/discourse-trendy-login/pull/3
I had to remove some customization settings to make it work with new static login page, but the component still allows adding a custom background gradient/image and allows adding detailed description on login modal. Here is how it looks with above changes:
Compared with how it looks without the component installed:
7 Likes
Your changes are now merged so I gave it a spin. Looks great!
The only issue I am finding is that it is now displaying both the contents of the site description admin setting and the contents of the login subheader field from the theme component.
It should, methinks, only display the contents of the login subheader field.
3 Likes
Agreed, fixed via:
https://github.com/discourse/discourse-trendy-login/commit/9ec246d90b5943281c62bb3d0f69d5949ef91a05
5 Likes