Triple-clicking the last (or only) paragraph in a post does not toggle the “Quote” button, at least for me in Chrome 57.0.2987.133.
It looks like this has been fixed previously, but may have resurfaced.
OK so this is a particular thing that I tend to do over and over, I double click paragraphs while I’m reading and the reply button doesn’t actually show up if I select the last paragraph. Presumably because chrome’s selection thing randomly includes bits of the chrome too (it seems to select a little bit after the newline, highlighting at the start of the ‘like’ heart). I don’t know if this is fixable or worth fixing but I thought it should be reported.
Another thing I’d like is a user-option t…
…so you probably can’t triple-click this text to quote it in a new reply.
3 个赞
dax
(Daniela)
2017 年5 月 1 日 15:43
2
You’re right, it’s relating to Chrome. With Firefox there’s no problem, triple click works very well.
5 个赞
Sujan
(Jan P.)
2017 年5 月 9 日 10:25
3
Same on Chrome in ChromeOS:
Version 57.0.2987.148 (64-bit)
Plattform 9202.66.0 (Official Build) stable-channel falco
Firmware Google_Falco.4389.92.0
1 个赞
sam
(Sam Saffron)
2017 年5 月 9 日 13:33
4
I think this is only the last paragraph, I believe @zogstrip worked on making this more robust in the past, looks like there is an edge case.
zogstrip
(Régis Hanol)
2017 年5 月 9 日 13:35
5
I think @tgxworld removed/changed my fix. I don’t recall why though
1 个赞
tgxworld
(Alan Tan)
2017 年5 月 9 日 13:45
6
Which commit was it? I definitely did not remove it intentionally.
zogstrip
(Régis Hanol)
2017 年5 月 9 日 13:46
7
1 个赞
tgxworld
(Alan Tan)
2017 年5 月 9 日 13:49
8
Ah that commit was fixing the quote button appearing when highlighting the “like” count text. I’ll have a look.
zogstrip
(Régis Hanol)
2017 年5 月 9 日 13:53
10
When triple-clicking the last paragraph, the selection spans over the .cooked
div and starts selecting content from the .post-menu-area
section.
This is why I added these lines
https://github.com/discourse/discourse/blob/master/app/assets/javascripts/discourse/lib/utilities.js.es6#L92-L94
It’s the most reliable way I could find. There’s one thing I didn’t try: adding a .quotable
div inside the .cooked
div and ensure only that div is selectable.
But another fresh pair of won’t hurt
4 个赞
tgxworld
(Alan Tan)
2017 年5 月 9 日 13:56
11
Yea I’ll have to look through the code path again since it has been awhile.
4 个赞
tgxworld
(Alan Tan)
2017 年5 月 11 日 08:52
12
7 个赞
tgxworld
(Alan Tan)
关闭
2017 年5 月 13 日 10:00
13
This topic was automatically closed after 2 days. New replies are no longer allowed.