It does happen when you have chat separate sidebar mode setting to always, and when you click on the button from the sidebar.
The chat route doesn’t fail ; the chat opens, but it still throws an error in the console:
It seems async/await is the issue (introduced recently here ).
3개의 좋아요
Moin
2월 21, 2024, 2:08오전
3
Maybe that is the problem @ranjeet reported here Chat buttons not working
1개의 좋아요
Good point. I can’t reproduce his issue, though.
I can see why he got the error when he hit the same button as me, but the other places don’t seem directly related. For example, the chat icon at the top doesn’t use the same way to redirect to the chat page.
1개의 좋아요
j.jaffeux
(Joffrey Jaffeux)
2월 22, 2024, 12:26오후
5
I can’t reproduce this issue, locally or on meta.
j.jaffeux
(Joffrey Jaffeux)
2월 22, 2024, 12:49오후
6
OK I understood; it’s when you have no public channels.
1개의 좋아요
That’s odd, I do have one, I believe.
Safe mode on themes, and all plugins disabled. Chat settings are all default except chat separate sidebar mode.
j.jaffeux
(Joffrey Jaffeux)
2월 22, 2024, 1:05오후
8
2개의 좋아요
I tried the change manually, but I still get the error :
I will try to unload all the plugins or try a new dev instance.
j.jaffeux
(Joffrey Jaffeux)
2월 22, 2024, 1:22오후
10
Don’t know, all I can say is that I could repro before, and I can’t after this change.
No worries, thanks. I don’t know what’s going on either.
I tried again with only the default plugins and safe mode on themes. I get the same result.
EDIT:
I wanted to delete all the channels. I started with the Staff channel and got an error on deletion.
I could still delete all the channels (even though I got errors with Staff and General).
I created again only one public channel General, and I still get the error:
My dev instance is up to date without any plugins/themes.
I will reset my dev instance; I don’t know if something went wrong with the DB or something else.
To give another example of a different context, I upgraded a production Discourse from 3.2.0-dev4 to the latest (which includes the fix), and the error happens as well. (it was working fine before the upgrade)
Sorry for not giving any helpful information. I will try to investigate and will get back to you if I figure out something.
Don
2월 22, 2024, 5:52오후
13
Hello, I can repro it on Meta too.
Repro:
Set chat to drawer mode
Show separate sidebar modes for forum and chat
When chat is in fullscreen OR
Always
Click sidebar Chat
When I open the full page chat with the sidebar button, I don’t see the error.
2개의 좋아요
Thanks, Don; I just realized we can set the mode on the user’s preference page.
At least, I’m not crazy.
2개의 좋아요
j.jaffeux
(Joffrey Jaffeux)
2월 23, 2024, 3:45오후
15
This error is really harmless and is expected, I will just silence it:
https://github.com/discourse/discourse/pull/25841
4개의 좋아요
j.jaffeux
(Joffrey Jaffeux)
에 닫힘
2월 24, 2024, 3:46오후
16
This topic was automatically closed 24 hours after the last reply. New replies are no longer allowed.