Trust level 4 users cannot set topic timers anymore

When we upgraded to 1.9 the trust level 4 users seem to have lost their ability to set timers for topics. So they cannot auto-close topics or close them temporarily. They can close them in a regular manner, though.

This must be a bug or a regression. It cannot be intentional, right?

(We are on 1.9.1)

1개의 좋아요

Possibly, what do you think @tgxworld?

Topic timers are staff only at the moment: see Scheduling topics for future publication. I fully support giving TL4 users topic timer permissions, but that’d be a new Contribute > Feature, not a Contribute > Bug.

Trust level 4 had the feature in 1.8. No doubt about it.

Did it work though? When I tested this back in August the timer didn’t actually do anything when it was triggered:

https://meta.discourse.org/t/how-to-create-a-timed-topic/60731/9?u=jomaxro

We never experienced any problems. Here is a topic that was scheduled to close in 60 minutes by a TL4 user:

1개의 좋아요

Consider me confused then. Moving this back to Contribute > Bug. I’ll be quiet now and let the real engineer (@tgxworld) look at this when he comes in :grimacing:.

6개의 좋아요

@jomaxro Yea topic timers are supposed to be available to admins and users with trust level 4 or higher. Do you recall why we restricted it to staff only?

https://github.com/tgxworld/discourse/commit/e3e6fd6ea0ecf2611738127efc585afbf727d219

5개의 좋아요

It came from this topic: Scheduling topics for future publication. Topic timers were not working for TL4 users when I tested it (timers could be set but nothing would happen when they triggered), so Jeff said to disable it unless it was an easy fix.

4개의 좋아요

Ah icic. I’ll have a look then :slight_smile:

4개의 좋아요

Can you try reproducing this again? I tried locally but the timers were working fine for me. Thank you!

In the mean time, I’ve reverted

https://github.com/discourse/discourse/commit/5a57a454fe713080814736442a6feb4863ec8c70

4개의 좋아요

I can confirm that auto-close, close temporarily, auto-open, open temporarily, schedule publishing, and remind me all work for a TL4 user on try.

However, Auto-Delete does not appear to work.

7개의 좋아요

TL4 users cannot delete topics anyway, couldn’t you just remove auto delete for TL4 since that is the only problem.

5개의 좋아요

This is now fixed by @zogstrip

6개의 좋아요