Tags bekijken die voor iedereen zichtbaar zijn, maar dan toch niet zichtbaar zijn, zorgt er nog steeds voor dat de gebruiker de tags bekijkt

Functie
,
1

Let’s says Tag Group A is visible to Admins only. If its visibility is changed to Everyone, and a normal user sets a tag to Watching for them, once the tag is visible back to that group (e.g. Administrators), the user still watches the tags, and receives notifications, instead of being removed since it’s no longer visible to the normal user. And, the user has no way to remove the Watching status, since it doesn’t show up in the Preferences > Tracking page.

4 likes
2

I was trying to repro this on Meta yesterday, and err… the tag group got hidden so I’m kinda stuck with this now (though I still can’t see the tags).

1 like
3

I haven’t been able to repro this. Just to confirm, were these the steps you followed?

  1. You had a restricted tag group (admin-only), which should prevent non-admins from watching tags.
  2. You changed the tag group permission to “Tags can be used by everyone” allowing a non-admin user to see and watch a tag in that group.
  3. Then changed the tag group permission back to admin-only.

Also, which version of Discourse were you experiencing this on?

That’s likely because you don’t have sufficient permissions to manage tag groups here on Meta.

4

My repro steps:

  1. (As admin) From a tag group with some tags, set Tags are visible only to the following groups[1] to something like trust_level_0 from some other group the other user is not in
  2. In the other user, watch these tags under their page (set notification status there to ‘Watching’)
  3. (As admin) Revert the tag group visibility to what it once was, and create a topic with those tags
  4. Go back to the other user; if you go to ?state=watching, you will see that topic made (‘Watching’ status not removed)[2]

  1. I’ll test the ‘visible to everyone’ shortly ↩︎

  2. I didn’t get a notification when I tested it, but still saw in the list of topics watching because of the tags) ↩︎

1 like
5

Thanks, got it.

Confirmed, the “watched” status on topics that became watched solely because a user was watching a tag remains, even if the user later loses access to that tag after tag group permissions change. They’ll continue to receive notifications on those already “auto-watched” topics, but not on new topics created after the change.

I can see the case for treating this as expected behaviour rather than a bug, but I also see the downside of leaving hundreds of topics in a watched state. I’ll leave it to the broader team to decide how we want to handle this.

4 likes
6

Ah, that makes sense, thanks for taking a look!

1 like
8

This is a tricky one! I see where you’re coming from @NateDhaliwal but I don’t think this is a bug.

Watching a tag is a shortcut for watching topics. While the user had access to the tag, any topics created with it were automatically marked as watched. I don’t necessarily think it’s a bug that those topics remain watched just because they stopped watching the tag (by virtue of it being removed from their access).

But let me check with @hugh, our staff experience PM, to see if he agrees. I could probably argue in either direction but I think this likely should be considered a Feature request, and could cover broader tracking changes rather than just changes brought on by losing access to the tag.

2 likes
11

I feel the same - since the user isn’t watching any new topics in the tag, but only the ones they had already been granted access to, it feels reasonable to continue doing so (if they were getting notifications for new topics in the tag, I think that would be problematic). I can also see how it would make sense to stop watching topics in tags a user doesn’t have access to, regardless of their previous access to it.

This makes sense to me - since this isn’t really a bug as such, a feature request to change how this feature works would be the best way forward.

2 likes