Johani
15. Dezember 2021 um 06:39
2
Ein Teil davon befindet sich im Kern und ein Teil davon in der Komponente. Diese beiden PRs sollten das Problem beheben, wenn sie zusammengeführt werden
main ← hnb-ku:category-boxes-lock-icons
opened 06:27AM - 15 Dec 21 UTC
Context: https://meta.discourse.org/t/unable-to-alter-the-lock-icon-in-category-… boxes/212133
Instead of hardcoding the category lock icon, set it as a property that themes can override. This means that themes can avoid full template overrides.
The category title link already does that here.
https://github.com/discourse/discourse/blob/1472e47aae5bfdfb6fd9abfe89beb186c751f514/app/assets/javascripts/discourse/app/components/category-title-link.js#L5
https://github.com/discourse/discourse/blob/70eca1dc4e04e94eb326482b51ea2617656fa8a8/app/assets/javascripts/discourse/app/templates/components/category-title-link.hbs#L5
This PR makes it so the `categories-boxes` and `categories-boxes-with-topics` also do the same.
main ← hnb-ku:category-boxes-lock-icons-fix
opened 06:30AM - 15 Dec 21 UTC
context: https://meta.discourse.org/t/unable-to-alter-the-lock-icon-in-category-… boxes/212133
I sent a PR to fix the core side of this here
https://github.com/discourse/discourse/pull/15309
This PR makes the same adjustment here
https://github.com/discourse/discourse-category-icons/blob/main/javascripts/discourse/initializers/category-icons.js#L21-L23
to the `categories-boxes` and `categories-boxes-with-topics` components.
4 „Gefällt mir“