Unable to rename Tag Group's title ("Save" button stays grayed-out)

[Ryan_N]

Replicated this for testing purposes before posting. Workflow as follows:

1. Sign-in as Admin
2. Enter Tags from the hamburger menu
3. Click the lower (admin-only) hamburger menu and select “Manage Tag Groups.”
4. Click on a Tag Group’s title, which of course launches an editor like so:
   
   
5. Now modify the title–in this case, by deleting a word:
   
   

No option to save the changes. FWIW, this could be because I have no tags assigned to either of these groups right now. I’m still getting set-up and am only testing things out right now.

[radek3911 (doc)]

Can reproduce, but this only occurs if there are no tags in the group.

[simon]

I’m not sure if this is a bug or a UI issue. The UI prevents you from saving any changes to a tag group if there are no tags in it. Tested with the latest Discourse code, it’s not even possible to create a tag group without adding at least one tag to it. I think this is by design, but the UI isn’t giving great feedback about what’s going on.

[Ryan_N]

This makes sense Simon. I should have noted in my OP that before I attempted to rename the tag groups, I first deleted two test tags I produced within each ta group. All that remained was therefore tag groups themselves (without any tags in them).

[simon]

I had to do the same thing to test the issue. I think that ideally the user would be told that a tag group needs to have at least one tag. What is currently happening is that the button is disabled without explanation. That behaviour puzzled me the first time I ran into it.

[techAPJ (Arpit Jalan)]

@simon

I think that ideally the user would be told that a tag group needs to have at least one tag.

Done via:

https://github.com/discourse/discourse/commit/e54b5dadab9fa637d7e6a71c142fc97c0c9fda0c