Continuing the discussion from Uninitialized constant when uploading JPG:
This bug is back. Happening right now here on meta…
The “Uninitialized constant EXIFR::JPEG” bug has resurfaced. tophee reported the issue, which was confirmed by codinghorror. According to tgxworld, the problem occurred due to an accidental upgrade of the gem, which was previously fixed by not pinning the gem version.
A potential solution involves updating the fork of the image_optim gem, but tgxworld notes that this will be challenging due to the gem’s history. vinothkannans suggests that a PR by gerhard could resolve the issue.
tgxworld has since implemented a global timeout across the worker, which was merged into the official fork in this commit.
Continuing the discussion from Uninitialized constant when uploading JPG:
This bug is back. Happening right now here on meta…
Let’s see.. yep confirmed, why did we regress here @tgxworld?
Because the gem was accidentally upgraded again as we didn’t pin the gem version when it was fixed previously.
https://github.com/discourse/discourse/commit/bb959e85e6a360372298107b31151ac18190fc14
The proper solution is still to update our fork of the image_optim gem but that contains our patch to support timeout but I don’t expect an easy time updating it. There is some history to our fork of the gem, the timeout support that I work on previously was at the per worker level which isn’t ideal which is why the PR didn’t land into the gem. The plan is to add a global timeout across the worker.
Done in
https://github.com/toy/image_optim/pull/162
Hopefully it gets merged into the official gem this time ![]()
I updated our fork in
https://github.com/discourse/discourse/commit/72a34573796dedcba8a9275f6d45f5c83603c14f
This topic was automatically closed after 7 days. New replies are no longer allowed.