Upload-Modal-Fenster mit anpassbarer Warnung / Textbereich

andrei · 2. Juli 2021 um 10:04

The upload modal was removed in this PR:

FEATURE: use native file picker in composer (#13552)

committed 08:45AM - 30 Jun 21 UTC

We want to remove completely our custom modal for uploading files in composer an…d directly trigger the system file picker. This PR makes it happen. The fix is pretty simple since we already weren't using our custom modal on mobile. We just need to start using the same hidden <input type="file"> that we already use on mobile. It seems to be pretty tricky to test opening a system modal so I haven't added new tests. We already have other tests for file uploading though. We directly trigger jquery-File-Upload plugin hooks in those tests - https://github.com/discourse/discourse/blob/3dda926cb22751beced12b427dd14657b53b6dfe/app/assets/javascripts/discourse/tests/acceptance/composer-attachment-test.js#L89.

Now we just trigger system file pickers directly.

Thema		Antworten	Aufrufe
More flexible upload options for admin? Feature	6	1142	30. Mai 2019
Restrict uploads Theme component	16	3423	8. Januar 2024
How can we either hide or grey out the upload icon in the Edit window? We have uploading disabled UX	5	79	11. August 2025
Adding text to the box that pops up after you click the Upload Button Support	2	352	9. September 2020
[PAID] File sharing plugin Marketplace	3	1663	5. Juli 2019

Upload-Modal-Fenster mit anpassbarer Warnung / Textbereich

Verwandte Themen