Ventana modal de carga con advertencia personalizable / área de texto

andrei · 2 Julio, 2021 10:04

The upload modal was removed in this PR:

FEATURE: use native file picker in composer (#13552)

committed 08:45AM - 30 Jun 21 UTC

We want to remove completely our custom modal for uploading files in composer an…d directly trigger the system file picker. This PR makes it happen. The fix is pretty simple since we already weren't using our custom modal on mobile. We just need to start using the same hidden <input type="file"> that we already use on mobile. It seems to be pretty tricky to test opening a system modal so I haven't added new tests. We already have other tests for file uploading though. We directly trigger jquery-File-Upload plugin hooks in those tests - https://github.com/discourse/discourse/blob/3dda926cb22751beced12b427dd14657b53b6dfe/app/assets/javascripts/discourse/tests/acceptance/composer-attachment-test.js#L89.

Now we just trigger system file pickers directly.

Tema		Respuestas	Vistas
More flexible upload options for admin? Feature	6	1141	30 Mayo 2019
Insert placeholder text in post while uploading UX uploads	8	2484	3 Diciembre 2015
Should attaching an image be more obvious? UX	48	6873	11 Agosto 2016
Expanding notification for upload limit UX	6	1618	13 Abril 2016
Show image file size limit on user#preference page UX	26	5538	28 Febrero 2017

Ventana modal de carga con advertencia personalizable / área de texto

Temas relacionados